Repository navigation
fix(cli): centralize JSONL stdin scanning - #13
Merged
Merged
Conversation
Move rm's JSONL scanner behavior into shared stdin helpers so large lines use an explicit 10 MiB scanner buffer and return a clear invalid-input error instead of the default bufio token-too-long path. Keep rm's semantics for ignoring malformed records and extracting id values. Add focused CLI tests for valid JSONL id extraction, oversized JSONL lines, and max-ID enforcement. Closes #9 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Document the rule that future CLI stdin / JSON / JSONL parsing must extend internal/cli/stdin.go, and tighten the JSONL ID limit check so oversized batches are rejected before appending the next ID. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gm rmto reuse the helper while keeping its malformed-record and max-ID semanticsinternal/cli/stdin.goValidation
Closes #9